-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: improve how ENS information is provided #175
Open
brunomenezes
wants to merge
12
commits into
main
Choose a base branch
from
feat/improve-on-chain-calls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o use the one from @cartesi/services package.
…e env vars into turbo.json and ts declaration files.
…elpers to solve bulk update conflicts.
… Vercel Cron service configuration.
… ENS service, including logic to request data on missing addresses.
Add information for next explorer release v3.9.0
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12407612649Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are changes to improve how we check if an Address has ENS information (e.g., name, avatar) to show rather than just Hex addresses. The currently deployed version is very wasteful. It constantly goes into the on-chain to resolve the address name and then looks for an avatar, causing other problems with rate-limiting and quota in extreme cases.
The changes are mainly in the backend. The UI gets data during the first
load
to be used as a cache and has logic to ask for information during a read miss. The UI has noloading
status; it just asks for the information, making it available to the application and other users.Summary:
vercel.json
was added to configure the Cron schedule (currently once daily at midnight UTC). It will be visible in the dashboard once it hits theproduction
environment.Below, there is a diagram of how the system architecture works.