Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and cosmetic changes #75

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Lint and cosmetic changes #75

merged 4 commits into from
Sep 18, 2024

Conversation

tuler
Copy link
Member

@tuler tuler commented Sep 18, 2024

  • delete unused tests
  • delete unused var
  • delete unused type

@tuler tuler requested a review from endersonmaia September 18, 2024 04:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b183f7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

endersonmaia
endersonmaia approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@endersonmaia endersonmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, you could also fix all Dockerfile warning we're getting at GitHub.

It's up to you do this on this PR or another.

@endersonmaia endersonmaia mentioned this pull request Sep 18, 2024
Merged
@tuler tuler force-pushed the feature/config-file-lint branch from 672bae6 to b183f7f Compare September 18, 2024 13:06
@tuler tuler requested a review from endersonmaia September 18, 2024 13:08
@tuler tuler merged commit 8d5ae87 into feature/config-file Sep 18, 2024
2 checks passed
@tuler tuler deleted the feature/config-file-lint branch September 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endersonmaia endersonmaia Awaiting requested review from endersonmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuler @endersonmaia