Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workaround assert rolling template #108

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: workaround assert rolling template #108

merged 1 commit into from
Oct 22, 2024

Conversation

stskeeps
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: fe8eed0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stskeeps stskeeps force-pushed the fix/workaround-assert-rolling-template branch from 9a99ca6 to fe8eed0 Compare October 22, 2024 07:10
@endersonmaia endersonmaia requested a review from tuler October 22, 2024 12:11
@endersonmaia
Copy link
Contributor

@tuler sholud we wait it to be fixed upstream (cartesi/machine-emulator#284) or merge this hotfix?

this shall require patch release for sdk and cli

@tuler
Copy link
Member

tuler commented Oct 22, 2024

I understand this only affects emulator 0.18.1, not 0.16.1, right?

@stskeeps
Copy link
Contributor Author

I understand this only affects emulator 0.18.1, not 0.16.1, right?

correct, this was broken with new CMIO so

@endersonmaia
Copy link
Contributor

I understand this only affects emulator 0.18.1, not 0.16.1, right?

correct, this was broken with new CMIO so

so this should target the next cli release at prerelease/v2-alpha branch

@tuler
Copy link
Member

tuler commented Oct 22, 2024

so this should target the next cli release at prerelease/v2-alpha branch

No, we already released SDK with emulator 0.18.1.
This fix can go to main under a SDK patch.

@stskeeps stskeeps merged commit 20baf3d into main Oct 22, 2024
2 checks passed
@stskeeps stskeeps deleted the fix/workaround-assert-rolling-template branch October 22, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuler tuler tuler approved these changes

Assignees
No one assigned
Labels
sdk v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stskeeps @endersonmaia @tuler