Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump to ubuntu:24.04 #10

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

endersonmaia
Copy link
Contributor

@endersonmaia endersonmaia commented Sep 9, 2024

This pull request includes significant updates to multiple Dockerfiles to standardize the build process and improve consistency across different languages. Additionally, there are minor code improvements in C++, Go, and Rust files. The most important changes include the introduction of snapshot-based package management, updates to build stages, and minor code cleanups.

Dockerfile Improvements:

  • Introduced snapshot-based package management to ensure consistent package versions (cpp-low-level/Dockerfile, cpp/Dockerfile, go/Dockerfile, lua/Dockerfile, ruby/Dockerfile, rust/Dockerfile). [1] [2] [3] [4] [5] [6]
  • Split Dockerfile stages into base, builder, and runtime stages for better modularity and reuse (cpp-low-level/Dockerfile, cpp/Dockerfile, go/Dockerfile, lua/Dockerfile, ruby/Dockerfile, rust/Dockerfile). [1] [2] [3] [4] [5] [6]
  • Removed redundant apt-get update commands and unnecessary package installations to streamline the Dockerfiles (cpp-low-level/Dockerfile, cpp/Dockerfile, go/Dockerfile, lua/Dockerfile, ruby/Dockerfile, rust/Dockerfile). [1] [2] [3] [4] [5] [6]

Code Improvements:

  • Changed wget to curl for downloading dependencies in the Makefile to improve reliability (cpp/3rdparty/Makefile).
  • Updated the type of the request parameter in the get_ioctl_name function to long int to match the expected type (cpp-low-level/dapp.cpp).
  • Replaced ioutil.ReadAll with io.ReadAll and fixed formatting issues in Go source files (go/src/dapp.go, go/src/rollups/helpers.go). [1] [2]

These changes aim to enhance the maintainability and consistency of the codebase while ensuring that Docker images are built in a reproducible manner.

@endersonmaia endersonmaia force-pushed the feature/bump-to-ubuntu-24.04 branch from 6cd957b to 4595825 Compare October 2, 2024 11:31
- using io instead of io/ioutils
- add field name to Struct literal at FinishRequest
- using for {} instead of for true {}
- add missing formmating directive for fmt.Errorf
@endersonmaia endersonmaia force-pushed the feature/bump-to-ubuntu-24.04 branch from 4595825 to a2daec0 Compare October 2, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant