Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to multiple Dockerfiles to standardize the build process and improve consistency across different languages. Additionally, there are minor code improvements in C++, Go, and Rust files. The most important changes include the introduction of snapshot-based package management, updates to build stages, and minor code cleanups.
Dockerfile Improvements:
cpp-low-level/Dockerfile
,cpp/Dockerfile
,go/Dockerfile
,lua/Dockerfile
,ruby/Dockerfile
,rust/Dockerfile
). [1] [2] [3] [4] [5] [6]cpp-low-level/Dockerfile
,cpp/Dockerfile
,go/Dockerfile
,lua/Dockerfile
,ruby/Dockerfile
,rust/Dockerfile
). [1] [2] [3] [4] [5] [6]apt-get update
commands and unnecessary package installations to streamline the Dockerfiles (cpp-low-level/Dockerfile
,cpp/Dockerfile
,go/Dockerfile
,lua/Dockerfile
,ruby/Dockerfile
,rust/Dockerfile
). [1] [2] [3] [4] [5] [6]Code Improvements:
wget
tocurl
for downloading dependencies in theMakefile
to improve reliability (cpp/3rdparty/Makefile
).request
parameter in theget_ioctl_name
function tolong int
to match the expected type (cpp-low-level/dapp.cpp
).ioutil.ReadAll
withio.ReadAll
and fixed formatting issues in Go source files (go/src/dapp.go
,go/src/rollups/helpers.go
). [1] [2]These changes aim to enhance the maintainability and consistency of the codebase while ensuring that Docker images are built in a reproducible manner.