Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless GET Parameter Support #166

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Stateless GET Parameter Support #166

merged 1 commit into from
Jan 27, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jan 27, 2024

Description:

Related issue (if applicable): n/a

GET parameters title, type, and format can be passed on the URL to provide default values if nothing in the message body exists (this is already how Stateful Apprise POSTs are handled). This is merely making both consistent.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • Tests added

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (2b21ab7) to head (1da364b).
Report is 32 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files           7        7           
  Lines         785      791    +6     
=======================================
+ Hits          780      786    +6     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 97abaa4 into master Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants