Honor default autotype #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file "analyzer" was checking whether the pass file contained an
"autotype" field: if it did, it would do nothing; and if it didn't, then
it would use a hardcoded "autotype" value (user :tab pass).
This caused issues down the line because the code that would use the
config's values would always find an existing "autotype" value (whether
hardcoded in rofi-pass or supplied by the pass file), and would never be
able to apply the settings from the config file.
I would suggest (re)-using the fields ("autotype" in that case) with
values in order of preference; but for the moment, this patch does the
job.
1. autotype="user :tab pass" # hardcoded
2. if config exists and supplies it, then autotype="whatever is in
config"
3. if the pass file supplies it, then autotype="whatever is in pass
file"
Fixes carnager#227
|
can you update this to latest master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.