Add support for "showfields" in entries #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
changed the title
moviuro
reviewed
Mar 4, 2019
| @@ -19,6 +19,10 @@ USERNAME_field='user' | |||
| AUTOTYPE_field='autotype' | |||
| OTPmethod_field='otp_method' | |||
|
|
|||
| # Display these fields with entries. | |||
| # NOTE: no default here, handled in code. | |||
| SHOWFIELDS_field='showfields' | |||
There was a problem hiding this comment.
Typo? Shouldn't that be show_fields?
There was a problem hiding this comment.
No, it's the name in the entry, i.e. you can have showfields: autotype to only get "autotype" in the dialog.
show_fields is the var that rofi-pass uses to display them.
There was a problem hiding this comment.
Please update the documentation accordingly, as it makes it easier to grasp the concept 😉
There was a problem hiding this comment.
Will do - waiting for some approval that this is good in general first.
It would go to README.md then, right?
There was a problem hiding this comment.
Yep, README.md is the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158.