59 behave tests improvement #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- attempt to mock out the get/post/delete calls the api is doing.
- refactor code from classes that don't need the self_ arguments into a helpers file - started to use unittest files for testing. The behave tests were great until the PurpleAir API team put limits/quotas on their public API.
- enabling the tests action for now.
- added test_construct_store_sensor_data_type
- testing as much as possible for PurpleAirDataLogger public interfaces. Next step is move out more logic so the while true loops just call other functions that can be tested individually
- added new method flatten_single_sensor_data so that it can be tested in isolation from the run method.
- done with test_flatten_single_sensor_data
- adding what needs to be covered
- filled out test_logic_for_storing_single_sensor_data and figured out unittest.mocks :)
- flushed out test_logic_for_storing_multiple_sensors_data
- adding coverage for test_logic_for_storing_group_sensors_data
- added more cover for group sensor logic. adding and not adding sensor group
- fixing the coverage for group logic
- even more coverage for group sensors
- adding more group sensor logic coverage
- fixing imports for github action
- adding coverage for local sensors
- sphinx docs with new helpers module
Closed
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
- tweaking sphinx yml one last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PurpleAirAPI now has limitations on API calls and a "Pay-To-Use" model, the tests are now unit tests instead of behavior tests. I'll leave the old behavior tests around for a bit. The new tests live under
tests