Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to OCKHealthKitOutcome #639

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

updates to OCKHealthKitOutcome #639

wants to merge 19 commits into from

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 29, 2022 •
edited
Loading

Add async/await support for iOS 13 and watchOS 6.

  • Renamed OCKObjectCompatible.swift -> OCKVersionedObjectCompatible.swift to match protocol name
  • Made OCKHealthKitOutcome conform to OCKVersionedObjectCompatible
  • Add OCKHealthKitOutcome to OCKEntity

erik-apple
erik-apple reviewed Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@erik-apple erik-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I’ll look over this soon! Thank you!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Feb 3, 2022 •
edited
Loading

@erik-apple I added some missing properties to OCKHealthKitOutcome. Though some of these aren't used currently, I made them match OCKOutcome as I suspect they will be needed in the future. I didn't physically add OCKHealthKitOutcome to CoreData as I'm guessing there may be another linkage along with more discussion to handle this properly.

I also marked some important properties as internal in the concrete OCK objects. I did this because I believe they were internal before the winter update and they probably shouldn't be manipulated by developers. Let me know if you need me to make some adjustments.

@cbaker6 cbaker6 changed the title add async/await support to iOS 13 updates to OCKHealthKitOutcome Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-apple erik-apple erik-apple left review comments

@YanceeMcDaniel YanceeMcDaniel YanceeMcDaniel approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbaker6 @erik-apple @YanceeMcDaniel