-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fanout after contest #1313
Fix fanout after contest #1313
Conversation
We are able to simulate closing with initial snapshot while we had a snapshot with one tx already. This reveals the bug where we previously saw H25 error related to contest deadline not being pushed.
This also adds HeadContested state changed event to update the contestation deadline in the HeadState. By updating it on contest observations, the fanout transaction creation will use the right correct deadline and passes tests.
c9f0e72
to
76d10e1
Compare
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2024-02-21 16:05:46.035740292 UTC Baseline Scenario
Baseline Scenario
|
8145eea
to
3072482
Compare
3072482
to
19842f6
Compare
This adds the observed contestation deadline to also inform users when the deadline will be (for informational purposes). The ReadyToFanout output should still be the authorative source for when fanout is possible.
e5654b1
to
e974f06
Compare
Fixes #1260
🐛🔨 Add
CloseWithInitialSnapshot
action to the model based tests to simulate the scenario outlined in #1260 where we see a close with the initial snapshot and consequently acontest
transaction.🐛 🔨 Fix
HeadLogic
andChain.Direct.Tx
to correctly observe and update thecontestationDeadline
inHeadState
.🐛 🔨 Add
contestationDeadline
toHeadIsContested
server output to also communicate the observed deadline to clients.