Skip to content

Commit

Permalink
remove inaccurate fixme
Browse files Browse the repository at this point in the history
  • Loading branch information
cardenaso11 committed Feb 15, 2024
1 parent adc3e7f commit fe72281
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions hydra-node/src/Hydra/Node.hs
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,10 @@ processNextStateChange HydraNode{persistence} sinks sc = do
(putEventToSinks @m @(StateChanged tx)) sinks sc
atomically $ modifyTVar (lastStateChangeId persistence) (+ 1)

-- FIXME(Elaine): put this whole thing in a single `atomically` call
-- that should be possible but there's some annoying classy monad transformer types to deal with

--NOTE(Elaine): think you shouldnt be able to put all above into a single atomically call, the types shouldnt allow that
-- some of the sinks won't be atomic, even if the disk-based persistence is
-- and actually it doesn't matter if we accidentally do the same event twice because the PERSISTENCE is in charge of at-least-once semantics

processEffects ::
( MonadAsync m
Expand Down

0 comments on commit fe72281

Please sign in to comment.