Patch for tx_info and block_tx_info (collateral_tx_out) #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The outputs for
collateral_tx_out
are never really created on chain - and thus, any assets involved are never committed toma_tx_out
. However, current references forcollateral_tx_out
intx_info
andblock_tx_info
endpoints does an incorrect join assumingcollateral_tx_out.id
can be joined againstma_tx_out
->tx_out_id
(latter is strictly only to be mapped againsttx_out.id
) . This resulted in collateral_tx_out returning inconsistent and wrong results across instances due to invalid key to join.Which issue it fixes?
#284
How has this been tested?
Tested on local preprod instance using below (should be empty):