Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include burn asset transactions in asset_txs #276

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

rdlrt
Copy link
Contributor

@rdlrt rdlrt commented Apr 12, 2024

Description

  • Include transaction where asset is burnt , as it is outside of input/output view
  • Add a distinct on transaction hash

Which issue it fixes?

#274

…output view, and add a distinct on transaction hash
@rdlrt rdlrt requested a review from Scitz0 April 12, 2024 08:16
Copy link
Contributor

@Scitz0 Scitz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdlrt rdlrt merged commit 0bbf806 into v1.1.1rc Apr 12, 2024
2 checks passed
@rdlrt rdlrt deleted the asset_txs_patch branch April 12, 2024 11:44
@rdlrt rdlrt mentioned this pull request Apr 15, 2024
24 tasks
rdlrt added a commit that referenced this pull request May 4, 2024
## Description
<!--- Describe your changes -->
Todo:
- [x] Update active_stake_cache, no longer requires maintaining account
active stake lookup, remove log scan references
- [x] Perf improvement for address_txs for 90% of addresses (postgres
filtering nuance)
- [x] Update cip67_strip_label
- [x] Reduce asset info cache rollback to 250
- [x] Update specs (view updates already covered in previous commits,
didnt see much to do beyond bumping version)
- [x] Retire stake_distribution_new_accounts_update (current query is
overkill)
- [x] Adapt as per 13.2.0.1 schema
  - [x] Replace consumed_by_tx_in_id
  - [x] Replace pool_offline_data
- [x] Update epoch references (no longer need 2 epoch wait time) for
cache
  - [x] Remove leftover tx_in references
- [x] MIRs (both extract from reserves as well as treasury) are no
longer in rewards table, but moved to it's own `instant_rewards` table -
update endpoints impacted (I think that's primarily SDC only)
- [x] Update `reserve_withdrawals` and `treasury_withdrawals` to include
`earned` and `spendable` epochs
- [x] Add an endpoint for asset/policy mint history
- [x] Retire asset_address_list and asset_policy_info (was deprecated 3
versions ago, and usage-wise had only a single hit in past 48 hours on
mainnet)
- [x] Fix script_utxos ->> asset_list
- [x] New endpoint + cron job to get current protocol parameters
- [x] Add is_dangling_delegation check
- [x] Specs Testing on guildnet
- [x] Update changelog

Bugs from testing:
- [x] Fix script_utxos, asset_list was not being returned as array ,
closes #272
- [x] Include burn asset transactions in asset_txs , closes #276 
- [x] tx_info: Fix spend_redeemers CTE Join condition, closes #275

- [x] Update Changelog/specs post testing results

---------

Co-authored-by: KoT_B_KocMoce <[email protected]>
Co-authored-by: XRAY | Robot <[email protected]>
Co-authored-by: Scitz0 <[email protected]>
Co-authored-by: Greg Beresnev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants