-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP67 decode fix #265
CIP67 decode fix #265
Conversation
Thanks for the PR, the better solution (to not have to update at every destination) for this one was to address the RETURNS type from the function itself (addressed here . Let me know if that has any conflict and we can work through it (PS: That branch is working through breaking changes using sancho-3-0-0 tag from dbsync repo) |
Okay, that's better. |
This fix doesn't work, because it's not about the returned type from the function. The point is that the string is encoded for the second time already encoded before. For ENCODE(,'escape') to work we need to pass a bytea string there, for which we need to decode (like here) the string in the middle. What we end up with is:
Instead of:
|
I still prefer to make changes in function that's only used by asset_info rather than individual endpoints (also, as before - asset_info.sql is deprecated , and around only for compatibility with v0), Check out linked commit |
Now that should work! Thanks for the quick fix |
Double encoding doesn't work as expected, since the input should be a decoded string