Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip-icon): button should have explicit type #2071

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Dec 7, 2024

The button element should have an explicit type="button" to avoid inadvertent form submission. If inside a form, the implicit role is "submit."

@metonym metonym merged commit 18c964e into master Dec 8, 2024
3 checks passed
@metonym metonym deleted the tooltip-icon-button branch December 8, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant