Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion)!: integrate Accordion with v11 #1947

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Mar 31, 2024

Supports #1629

This aligns Accordion with the v11 styles and API.

Breaking Changes

  • Remove xl size prop. Valid sizes are sm | md | lg. Default is md.
  • Remove skeleton prop. AccordionSkeleton is used separately.
  • Remove $$restProps and unnecessary forwarded events.
  • AccordionSkeleton is no longer open by default (flip the boolean). This more closely aligns with the AccordionItem behavior.

New Features

  • Add a flush prop to flush align accordion item text.

Fixes

  • Apply the layer-size class to fix sizing.
  • Add an aria-controls id for the expando button.

Clean-up

  • Fix JSDoc comment formatting, adjust copy where appropriate.
  • Use shorthand for context instead of manually subscribing/unsubscribing.
  • Improve the documentation by adding more descriptions and auditing examples.

@metonym metonym merged commit 0e8909a into next/v11-styles Apr 21, 2024
1 check passed
@metonym metonym deleted the next/v11-styles-accordion branch April 21, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant