Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio-button-group): strongly type dispatched change/select events #1819

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(radio-button-group): strongly type dispatched change/select events #1819

merged 1 commit into from
Oct 3, 2023

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Oct 3, 2023 •
edited
Loading

Strongly type the event.detail as string for RadioButtonGroup and TileGroup. Currently, it defaults to any since the type is not explicitly annotated.

<RadioButtonGroup
  legendText="Storage tier (disk)"
  selected="standard"
  on:change="{(e) => {
    console.log(e.detail); // string
  }}"
/>

@metonym metonym changed the title fix(radio): strongly type dispatched change/select events fix(radio-button-group): strongly type dispatched change/select events Oct 3, 2023
@metonym metonym force-pushed the fix-radio-dispatch-types branch from f68fb08 to c8667c1 Compare October 3, 2023 18:21
@metonym metonym merged commit 06d81dd into master Oct 3, 2023
2 checks passed
@metonym metonym deleted the fix-radio-dispatch-types branch October 3, 2023 18:23
@metonym
Copy link
Collaborator Author

metonym commented Oct 13, 2023

Fixed in v0.81.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metonym