-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update User and Maintainer Docs #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM, dont have any concern.
Had some doubt about how the merging/override works but it is address in https://github.com/caraml-dev/mdformatter?tab=readme-ov-file#formatting
One more minor clarification, so the workflow for updating docs
- Edit template/values
- Make docs
- Verify generated MD locally
- Commit and push generated MD to branch
- MR
Yes, that's correct. |
Thanks for the quick review, @leonlnj ! Will merge this PR shortly. |
Description
This PR updates the user docs and adds minimal maintainer docs for Merlin.
Note: Both the sets of docs are templatised using Jinja2 and the
generated/*
folder contains the final docs for Gitbook that are created by running the following locally:Modifications
docs/.gitignore
- Ignore the mdformatter files used for formattingdocs/Makefile
- Add make targets for the docsdocs/README.md
- Include broad info about the different types of docs in the repodocs/SUMMARY.md
- This file is not needed by the CaraML Gitbook docs and is removed.docs/developer/
- Minor corrections to the links in the dev docsdocs/images/
- Add / update imagesdocs/maintainer/
- Add maintainer docs.docs/maintainer/values.json
- Values file for the maintainer docspage-title
is added to the.md
files, to be able to publish the docs to Confluence, if needed.generated/
subfolder contains the final generated docs.docs/user/
- Add user docs.docs/user/values.json
- Values file for the maintainer docspage-title
andparent-e-title
is added to the.md
files, to be able to publish the docs to Confluence, if needed.generated/
subfolder contains the final generated docs.examples/
- Renaming the notebooks referenced by the user docs to replace spaces with hyphens, to overcome limitation # 4 of the doc formatting tool: https://github.com/caraml-dev/mdformatter?tab=readme-ov-file#limitationsTests
The following updates / tests are to be done after this PR is merged:
caraml-dev/docs
repo, in particular, the SUMMARY.md file, to point to thegenerated/**
doc files from Merlin repo.Checklist
Release Notes