Upgrade miniforge version in all Dockerfiles #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
changed the title
krithika369
commented
Sep 8, 2023
| @@ -9,7 +9,7 @@ pip install -r requirements_docs.txt | |||
|
|
|||
| Install `pandoc` | |||
| ```bash | |||
| conda install -c conda-forge pandoc=1.19.2 | |||
There was a problem hiding this comment.
-c conda-forge doesn't need to be specified explicitly anymore as it's the default channel.
There was a problem hiding this comment.
Technically we don't need to change this right? Since this is going to be run by the users themselves and we don't really know or care about which repository they're going to use 🤔
krithika369
requested review from
ariefrahmansyah,
deadlycoconuts and
tkpd-hafizhan
deadlycoconuts
approved these changes
Sep 8, 2023
ariefrahmansyah
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Anaconda repo is no longer free for use, for companies with over 200 employees: https://community.anaconda.cloud/t/is-conda-cli-free-for-use/14303
This PR replaces
continuumio/miniconda3used as the Python SDK docs base image with an image that uses Miniforge. With Miniforge:Related PR on Turing: caraml-dev/turing#360
Additionally, the existing references to
miniforge/condaare updated to the latest version.Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?:
Checklist