Fix sdk deploy method

caraml-dev · May 20, 2024 · b69c772 · b69c772
1 parent 9c82fd2
commit b69c772
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/python/sdk/merlin/model.py b/python/sdk/merlin/model.py
@@ -1268,6 +1268,7 @@ def deploy(
                 min_replica=resource_request.min_replica,
                 max_replica=resource_request.max_replica,
                 cpu_request=resource_request.cpu_request,
+                cpu_limit=resource_request.cpu_limit,
                 memory_request=resource_request.memory_request,
             )
             if (
@@ -1748,6 +1749,7 @@ def _get_default_resource_request(
                     env.default_resource_request.min_replica,
                     env.default_resource_request.max_replica,
                     env.default_resource_request.cpu_request,
+                    env.default_resource_request.cpu_limit,
                     env.default_resource_request.memory_request,
                 )
 
@@ -1762,6 +1764,7 @@ def _get_default_resource_request(
             min_replica=resource_request.min_replica,
             max_replica=resource_request.max_replica,
             cpu_request=resource_request.cpu_request,
+            cpu_limit=resource_request.cpu_limit,
             memory_request=resource_request.memory_request,
         )
 
@@ -1807,6 +1810,7 @@ def _create_transformer_spec(
                 min_replica=resource_request.min_replica,
                 max_replica=resource_request.max_replica,
                 cpu_request=resource_request.cpu_request,
+                cpu_limit=resource_request.cpu_limit,
                 memory_request=resource_request.memory_request,
             )
 

diff --git a/python/sdk/test/integration_test.py b/python/sdk/test/integration_test.py
@@ -1237,7 +1237,7 @@ def test_redeploy_model(integration_test_url, project_name, use_google_oauth, re
             metrics_type=merlin.MetricsType.CPU_UTILIZATION, target_value=50
         ),
         deployment_mode=DeploymentMode.RAW_DEPLOYMENT,
-        transformer = Transformer(image="gcr.io/kubeflow-ci/kfserving/image-transformer:latest"),
+        transformer=Transformer(image="gcr.io/kubeflow-ci/kfserving/image-transformer:latest"),
     )
 
     with open(os.path.join("test/transformer", "input.json"), "r") as f: