Skip to content

Commit

Permalink
Remove forcible replacement of merlin-sdk dep
Browse files Browse the repository at this point in the history
  • Loading branch information
Krithika Sundararajan committed Sep 14, 2023
1 parent 277bdd6 commit 163075b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
11 changes: 6 additions & 5 deletions python/batch-predictor/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@
with open('requirements.txt') as f:
REQUIRE = f.read().splitlines()

merlin_path = os.path.join(os.getcwd(), "../sdk")
merlin_sdk_package = "merlin-sdk"
for index, item in enumerate(REQUIRE):
if merlin_sdk_package in item:
REQUIRE[index] = f"{merlin_sdk_package} @ file://localhost/{merlin_path}#egg={merlin_sdk_package}"
# TODO: Uncomment below lines after Pyfunc server stops supporting Python 3.7
# merlin_path = os.path.join(os.getcwd(), "../sdk")
# merlin_sdk_package = "merlin-sdk"
# for index, item in enumerate(REQUIRE):
# if merlin_sdk_package in item:
# REQUIRE[index] = f"{merlin_sdk_package} @ file://localhost/{merlin_path}#egg={merlin_sdk_package}"

setup(
name='merlin-pyspark-app',
Expand Down
12 changes: 7 additions & 5 deletions python/pyfunc-server/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@

# replace merlin relative path in requirements.txt into absolute path
# setuptools could not install relative path requirements
merlin_path = os.path.join(os.getcwd(), "../sdk")
merlin_sdk_package = "merlin-sdk"
for index, item in enumerate(REQUIRE):
if merlin_sdk_package in item:
REQUIRE[index] = f"{merlin_sdk_package} @ file://localhost/{merlin_path}#egg={merlin_sdk_package}"

# TODO: Uncomment below lines after Pyfunc server stops supporting Python 3.7
# merlin_path = os.path.join(os.getcwd(), "../sdk")
# merlin_sdk_package = "merlin-sdk"
# for index, item in enumerate(REQUIRE):
# if merlin_sdk_package in item:
# REQUIRE[index] = f"{merlin_sdk_package} @ file://localhost/{merlin_path}#egg={merlin_sdk_package}"

setup(
name='pyfuncserver',
Expand Down

0 comments on commit 163075b

Please sign in to comment.