Add recursive finder for filelike objects #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #268. |
|
@o-smirnov Tests are now passing (rebased on master after dropping 3.7). Feel free to add/change at your leisure. |
|
OK, I also added the following option to allow explicit user-specified binding of directories. Simple enough change. opts:
backend:
singularity:
bind_dirs:
~/tmp: rw
/tmp: ro @JSKenyon if the pipeline is in front of you now, could you please test this quickly? |
In progress. Have disabled my file finder and I am instead mounting everything manually. Will let you know once it runs through. |
|
@o-smirnov That seems to have worked. The combination of the finder and the override should be pretty foolproof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) does what it says on the tin. As @o-smirnov points out, this may be somewhat error prone. That said, I have added a handful of tests and the pipeline which originally identified the problem now runs through. In principle, the code could be further refined (the
typeguardpackage seems to be very useful), but I think that this should be enough for now. If more exotic types foil this approach, we can always add them to the test suite and iterate.