fix: use asynchronous hashing #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions for pull request titles! 🙏 |
G3root
commented
Aug 7, 2024
| @@ -48,19 +49,12 @@ async function authenticateWithAccessToken( | |||
|
|
|||
| const accessToken = await findAccessToken(clientId, c); | |||
|
|
|||
| if (!accessToken) { | |||
There was a problem hiding this comment.
The early bailout is vulnerable to timing attacks because the attacker can verify whether the ID exists in the database based on the timing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what this pr do
scryptSyncwithscryptwhich is asynchronous and doesn't block the event loop since it's a expensive operation https://nodejs.org/en/learn/asynchronous-work/dont-block-the-event-loop#what-code-runs-on-the-worker-pool