Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cs_support enum bug #160

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

GarntS
Copy link

@GarntS GarntS commented May 10, 2024

The enum capstone::Arch doesn't have the same values as capstone's cs_arch enum. This causes calls to supports_arch() to return incorrect results once the enum values diverge, which happens for riscv and a few others.

Fortunately, capstone_sys::cs_arch has a From<capstone::Arch> implementation, so we can just use that to do the correct conversion.

@tmfink tmfink merged commit 6d3ae9f into capstone-rust:master May 12, 2024
16 checks passed
@tmfink
Copy link
Member

tmfink commented May 12, 2024

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants