Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

New built-in steps #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cacaodev
Copy link

This PR add two steps:

  • A wait for n seconds step
  • A cappuccino-oriented step that checks the value of a given property in the application delegate.

}

@end
Copy link
Author

@cacaodev cacaodev May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the way errors are reported here, following the pattern i'm used to in obj-c: if there is no error (NO_ERROR) then it is a success.
If there is a convention in cucumber/ruby that I am not honoring, please tell me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any convention or something, we are used to use '{"result" : "OK"}'; or '{"result" : "__CUKE_ERROR__"}';
I think it would be better to continue like this for consistency

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, no custom error explaining the failure reason ?

Copy link
Member

@Dogild Dogild May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have something like {"result" : "__CUKE_ERROR__", "message" "Because blabla"}'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants