Add SPM support #55
Open
Add SPM support #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I am having trouble getting the CI to work. I'm not sure what to do for SPM testing, other projects like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area remove the test project. |
|
@all-contributors please add @aeharding for code. Let me take a quick look. |
|
I've put up a pull request to add @aeharding! 🎉 |
|
Build is passing! Had to migrate over the new |
|
@aeharding How did you verify this still works through CocoaPods? I"m having trouble verifying that. Did you test it with the example project? |
|
Hey @johnborges I tested with my project, Voyager, but I also just checked out the example project and it is working for me. Where are you having issues? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR adds SPM support for this plugin. It works well in my testing, including for Cocoapods (so it's backward compatible!)
Please let me know if you have any questions!