fix: Vertically center window title bar controls #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centers the title bar control buttons, but they will not be the full height of the title bar until Yaru is updated to include ubuntu/yaru.dart#967
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
- Coverage 89.22% 89.19% -0.03%
==========================================
Files 110 110
Lines 7515 7515
==========================================
- Hits 6705 6703 -2
- Misses 631 632 +1
- Partials 179 180 +1 ☔ View full report in Codecov by Sentry. |
CarlosNihelton
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centers the title bar control buttons, but they will not be the full height of the title bar until Yaru is updated to include ubuntu/yaru.dart#967 (will require a version bump on our end in the future).
UDENG-5289