-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint(windows-agent): Investigate skipping distros #902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 89.28% 89.35% +0.07%
==========================================
Files 110 110
Lines 7520 7533 +13
==========================================
+ Hits 6714 6731 +17
+ Misses 627 625 -2
+ Partials 179 177 -2 ☔ View full report in Codecov by Sentry. |
Now we have to upgrade the Go. I'm unsure if we should Go with the toolchain to 1.22.7 or migrate straight into 1.23.1. 1.23.0 is affected by the same vulnerability reported in ´go/parser`. |
The version of Go has been bumped to 1.23, so you'd just need to rebase this PR |
a65d3ad
to
1f1336f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tell me what you think about my comment or if you think this is unecessary.
As a aside, you will to rebase again due to conflicts :)
in Landscape newHostAgentInfo assembly due WSL internal errors which I couldn't reproduce outside of UP4W.
75baf7e
to
1e7898c
Compare
Rebased over the latest main, updated GoWSL dependency and implemented the looping. |
1e7898c
to
fdb3d8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking all good from my side!
That happens during construction of the status message sent to Landscape. If we skip a distro, Landscape understands it doesn't exist anymore and removes it from the dashboard. But that happens sometimes when an existing distro. It seems a WSL internal error.
ubuntu/GoWSL#120 should prevent the stdout and stderr messages to come empty as shown above.
Thus I'm updating GoWSL here.
That doesn't prevent the issue itself.
I couldn’t reproduce this outside of UP4W. I attempted building a small binary in Go doing the same steps as GoWSL does and put it to run during system startup in loop, rebooted the OS many times but no success. The few times I’ve seen this happening in the logs were early during app startup, so I suspect it may happen because some WSL internal component is not yet ready. Thus this PR: adding one-time retry if an error happens when attempting to retrieve a distro state.
Either that will prevent the issue once for all or at least give us more context about what causes that error.
UDENG-3722