fix: golangci-lint warnings about unsafe integer conversions #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosec 115 has been promoted into golangci-lint v1.60.2. That's about integer conversion. We're doing nasting conversions there: uintptr -> int (we're 64-bit, but still bad for portable type-safe code) uintptr -> uint32 (we relied on domain knowledge the compiler cannot ensure). This reimplements the low-level byte-counting to: - Merge two functions into one, reducing the risk of mistakes - Doing all the math with uint64 and - Finally validate that the amount we'd allocate is still <= MaxUint32. This way we don't surface the int conversions, but rather keep them isolated into a single function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.2 #882 +/- ##
========================================================================================================
+ Coverage 88.61% 88.87% +0.25%
========================================================================================================
Files 105 105
Lines 6806 6821 +15
========================================================================================================
+ Hits 6031 6062 +31
+ Misses 600 584 -16
Partials 175 175 ☔ View full report in Codecov by Sentry. |
CarlosNihelton
force-pushed
the
fix-ptr-int-conv
branch
from
6ff64e1 to
8d1cdd8
Compare
With one way that demonstrates we don't overflow uint32
It's too much close to the real system APIs :)
To prevent false warnings of narrow conversion from uintptr. StoreApiError aliased to int64 instead of int
CarlosNihelton
force-pushed
the
fix-ptr-int-conv
branch
3 times, most recently
from
e0efdbd to
174bee4
Compare
There is some non-negligible error translation in there mostly due the somewhat involving error handling imposed by syscall/dll_windows. This adds a modest set of test cases to cover that logic. For that to be approachable I extracted the error reporting out of the proc call method, this way we don't depend on calling a DLL function to test this part. Quite artificial setup, but I always enjoy separating "computing" from "doing".
CarlosNihelton
force-pushed
the
fix-ptr-int-conv
branch
from
174bee4 to
c250e5c
Compare
didrocks
requested changes
Aug 27, 2024
All about the semantics of calling a dll Proc.
At the expense of repeating the error handling.
didrocks
approved these changes
Aug 28, 2024
CarlosNihelton
merged commit 6afb8c3
into
dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.60.2
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the warnings were not a real issue, but the one around the Win32 GetAdapterAddersses was harder to prove with the previous implementation so I refactored it a little bit to make it easy to reach the piece of mind that we're not doing nasting error-prone narrowing conversions.
This should unblock #877 .
UDENG-4234