fix(gui): Slicker Landscape config page #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
========================================
Coverage 88.53% 88.53%
========================================
Files 89 105 +16
Lines 5930 6804 +874
========================================
+ Hits 5250 6024 +774
- Misses 539 604 +65
- Partials 141 176 +35 ☔ View full report in Codecov by Sentry. |
|
Thanks for this update. Could you show me a screenshot with the "custom config" option selected? |
|
There you go:
|
|
And their light versions as well:
|
As before, it's enabled by default in debug mode. In production model.isSaaSSupported returns false and the option is hidden from the radio group.
Per guidance in UDENG-3818.
CarlosNihelton
force-pushed
the
slicker-landscape
branch
from
dae464b to
c2bc89f
Compare
|
Just rebased on main to avoid merging the commits relategd to #873 together with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides the Landscape config option (instead of disabling it). No changes in behaviour nor in how we decide to hide it.
Some strings were changed also per guidance provided in #861.
Finally I added a little bit more spacing in the top now that the subtitle is one line only.
Here's how it looks like when compiled in release mode.
Closes #861
I'm purposefully basing this PR on top of #873 so I can stress CI to exercise the changes therein introduced. There is no dependency between the two tasks.
UDENG-3818