fix(agent): SHA256SUMS being looked up in the parent directory #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see log lines like below: time="2024-07-18T10:42:53-03:00" level=debug msg="Landscape: received command Install. Target: testDistro_UP4W_TestInstall_Error_when_the_checksum_entry_is_missing_for_the_rootfs_5721719220902747386" time="2024-07-18T10:42:53-03:00" level=info msg="checksums file \"http://127.0.0.1:57850/releases/SHA256SUMS\" not found" Notice the path to the checksums file (one dir above the expected - it should be /releases/theone/SHA256SUMS)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #842 +/- ##
==========================================
- Coverage 88.36% 88.28% -0.09%
==========================================
Files 105 105
Lines 6758 6758
==========================================
- Hits 5972 5966 -6
- Misses 612 617 +5
- Partials 174 175 +1 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't notice this behaviour in tests because our mocked file server was serving files in the root directory (since the parent of / is / everything just worked).
Changing tests to serve and search files inside a subdirectory reveal the problem: we're not looking for the checksums file beside the rootfs but rather in the parent directory. We see log lines like below:
UDENG-3669