fix: prevent subprocesses to sent notification to systemd #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset NOTIFY_SOCKET just after forwarding readyness to systemd. This way, subprocesses will not attempt to notify systemd that they are ready.
didrocks
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 88.31% 88.28% -0.03%
==========================================
Files 104 104
Lines 6700 6702 +2
==========================================
Hits 5917 5917
- Misses 611 613 +2
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset NOTIFY_SOCKET just after forwarding readyness to systemd. This way, subprocesses will not attempt to notify systemd that they are ready.
Unfortunately, this could only be tested in some e2e tests, grepping for subprocess warnings and we are not at that level of details yet in the e2e test infra.
UDENG-3363