-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows-agent): Landscape install: create user when no cloud-init file is provided #584
Draft
EduardGomezEscandell
wants to merge
10
commits into
main
Choose a base branch
from
cloudinit-create-user
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## landscape-cloud-init #584 +/- ##
=====================================================
Coverage 88.39% 88.39%
=====================================================
Files 52 52
Lines 2465 2465
=====================================================
Hits 2179 2179
Misses 228 228
Partials 58 58 ☔ View full report in Codecov by Sentry. |
EduardGomezEscandell
changed the base branch from
main
to
landscape-cloud-init
February 19, 2024 12:06
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
2 times, most recently
from
February 19, 2024 12:33
adf5ab4
to
ae023ab
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
February 19, 2024 12:34
6039f00
to
34c6d66
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
February 19, 2024 12:42
ae023ab
to
6cb17b5
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
February 19, 2024 12:44
34c6d66
to
0cdddb1
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
February 19, 2024 14:36
6cb17b5
to
25f22ee
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
3 times, most recently
from
March 4, 2024 09:11
dea785e
to
deb25bd
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
March 7, 2024 15:53
deb25bd
to
2e040bf
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
March 7, 2024 16:17
0cdddb1
to
b16fd51
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
March 11, 2024 15:01
56d92c4
to
f43572c
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
March 11, 2024 15:20
b16fd51
to
3d9b5e6
Compare
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
March 26, 2024 09:32
f43572c
to
1b13b75
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
March 26, 2024 09:33
3d9b5e6
to
a46480c
Compare
It also keeps its own config so we don't have to pass it around
Cloud-init is in charge of this now
EduardGomezEscandell
force-pushed
the
landscape-cloud-init
branch
from
March 27, 2024 10:10
1b13b75
to
8365c12
Compare
EduardGomezEscandell
force-pushed
the
cloudinit-create-user
branch
from
March 27, 2024 10:12
a46480c
to
866b0fd
Compare
CarlosNihelton
force-pushed
the
landscape-cloud-init
branch
2 times, most recently
from
April 5, 2024 02:43
9edafa4
to
abdfde5
Compare
CarlosNihelton
force-pushed
the
landscape-cloud-init
branch
2 times, most recently
from
April 19, 2024 14:40
32b202a
to
d3426c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before supporting cloud-init, Landscape created distros with a default user. This PR: