Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows-agent): Landscape install: create user when no cloud-init file is provided #584

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

EduardGomezEscandell
Copy link
Contributor

Before supporting cloud-init, Landscape created distros with a default user. This PR:

  1. Removes user creation when a cloud-init file is provided.
  2. Refactors the old user creation when no cloud-init file is provided.

@EduardGomezEscandell EduardGomezEscandell self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (8365c12) to head (866b0fd).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           landscape-cloud-init     #584   +/-   ##
=====================================================
  Coverage                 88.39%   88.39%           
=====================================================
  Files                        52       52           
  Lines                      2465     2465           
=====================================================
  Hits                       2179     2179           
  Misses                      228      228           
  Partials                     58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EduardGomezEscandell EduardGomezEscandell changed the base branch from main to landscape-cloud-init February 19, 2024 12:06
@EduardGomezEscandell EduardGomezEscandell force-pushed the landscape-cloud-init branch 2 times, most recently from adf5ab4 to ae023ab Compare February 19, 2024 12:33
@EduardGomezEscandell EduardGomezEscandell force-pushed the landscape-cloud-init branch 3 times, most recently from dea785e to deb25bd Compare March 4, 2024 09:11
@EduardGomezEscandell EduardGomezEscandell removed their assignment Mar 28, 2024
@CarlosNihelton CarlosNihelton force-pushed the landscape-cloud-init branch 2 times, most recently from 9edafa4 to abdfde5 Compare April 5, 2024 02:43
@CarlosNihelton CarlosNihelton force-pushed the landscape-cloud-init branch 2 times, most recently from 32b202a to d3426c8 Compare April 19, 2024 14:40
Base automatically changed from landscape-cloud-init to main April 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant