refactor(landscape): Refactor Landscape receive-commands tests #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests where bad for two reasons: 1. They were structured in a way that was hard to read 2. They had very little granularity: only one success and one failure test case per command. Adding new tests was quite hard, defeating the purpose of table testing. With this new structure, adding test cases is much simpler, so I added quite a few of them. This is relevant to an upcomming pull request regarding cloud-init integration.
CarlosNihelton
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns the Landscape service package tests that tested the execution of commands comming from the server. It is motivated by the attempt at adding new tests in PR #506 regarding cloud-init integration.
These tests where sub-par for two reasons:
Adding new tests was quite hard, defeating the purpose of table testing. With this new structure, adding test cases is much simpler, so I added quite a few of them.
A side effect of this PR is that the executor tests can no longer be ran without the mock. We were never running them anyways so I decided against maitaining unused code.