feat: Reorganize landscape page #1008
Open
+363
−682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 89.38% 89.13% -0.25%
==========================================
Files 113 113
Lines 7618 7522 -96
==========================================
- Hits 6809 6705 -104
- Misses 632 640 +8
Partials 177 177 ☔ View full report in Codecov by Sentry. |
This collapses the SaaS and custom configuration into one set of fields, and shows all fields at the same time.
No logic or UI changes here, just renaming variables.
ashuntu
force-pushed
the
organize-landscape-page
branch
from
c15d876 to
bb8ed80
Compare
|
This probably has a ways to go before it is ready, but I opened for review so we can get started on back and forth :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructures the Landscape page to use the 2 column layout. This comes with quite the large side effect of combining the SaaS and self-hosted configurations into a single set of fields, so there are quite a lot of changes here to support that.
This is based on and relies on #997 being merged first.
UDENG-5288