-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable saml integration #607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/synapse-operator into install_mas_cli_in_synapse_rock
…l/synapse-operator into install_mas_cli_in_synapse_rock
Thanhphan1147
force-pushed
the
disable_saml_integration
branch
from
November 28, 2024 22:07
2f80a83
to
392262f
Compare
javierdelapuente
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, just removing code!
amandahla
reviewed
Dec 3, 2024
…se-operator into disable_saml_integration
amandahla
approved these changes
Dec 3, 2024
Trivy vulnerability will be fixed here: |
Test coverage for e57cd83
Static code analysis report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec : ISD-185 (internal)
As authentication will be handled by the Matrix Authentication Service, the saml integration will need to be removed. Future revisions of synapse will therefore no longer support the saml integration.
Authentication via SAML is possible with Dex serving as a bridge ( via the dex-auth charm ) which will be possible once the oauth integration is added.
Checklist
src-docs
urgent
,trivial
,complex
)