Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable saml integration #607

Merged
merged 25 commits into from
Dec 4, 2024
Merged

Disable saml integration #607

merged 25 commits into from
Dec 4, 2024

Conversation

Thanhphan1147
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 commented Nov 26, 2024

Spec : ISD-185 (internal)

As authentication will be handled by the Matrix Authentication Service, the saml integration will need to be removed. Future revisions of synapse will therefore no longer support the saml integration.

Authentication via SAML is possible with Dex serving as a bridge ( via the dex-auth charm ) which will be possible once the oauth integration is added.

Checklist

@Thanhphan1147 Thanhphan1147 changed the base branch from main to 2/main November 28, 2024 16:53
@Thanhphan1147 Thanhphan1147 marked this pull request as ready for review December 2, 2024 10:08
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner December 2, 2024 10:08
Copy link
Collaborator

@javierdelapuente javierdelapuente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just removing code!

@amandahla
Copy link
Collaborator

Trivy vulnerability will be fixed here:
element-hq/synapse#17985

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test coverage for e57cd83

Name                                    Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------
src/actions/__init__.py                     1      0      0      0   100%
src/actions/register_user.py               21      0      2      0   100%
src/admin_access_token.py                   9      0      0      0   100%
src/backup.py                             175      5     20      2    96%   353-354, 423-424, 481->483, 484
src/backup_observer.py                    134     16     12      0    89%   132-135, 140-143, 179-182, 211-214
src/charm.py                              286     20     70     11    91%   132->134, 137, 243, 247-248, 254-255, 276-277, 305, 312, 393-397, 400-401, 429-431, 451, 487-488
src/charm_state.py                        157      9     34      7    92%   270, 274, 295, 320, 326, 332, 336-337, 420
src/charm_types.py                         30      0      0      0   100%
src/database_client.py                     57      1      8      4    92%   35, 47->exit, 69->exit, 88->98
src/database_observer.py                   39      0      4      1    98%   70->72
src/exceptions.py                           3      0      0      0   100%
src/matrix_auth_observer.py                60      5     12      3    89%   61, 64, 143, 162-163
src/media_observer.py                      41      4      2      1    88%   61-63, 82
src/mjolnir.py                             97      3     30      3    95%   82, 91->107, 112-116
src/observability.py                       14      0      0      0   100%
src/pebble.py                             203     25     46     12    85%   57->62, 176->exit, 187-191, 225-226, 246-247, 300->305, 310-311, 323-324, 326-327, 360, 362, 364, 366, 368, 396, 448-453
src/redis_observer.py                      35      3      4      0    92%   62-65
src/s3_parameters.py                       22      0      4      0   100%
src/smtp_observer.py                       56      4     14      2    91%   82-86, 89, 108->113
src/synapse/__init__.py                     4      0      0      0   100%
src/synapse/admin.py                       19      2      2      0    90%   40-41
src/synapse/api.py                        175      3     20      3    97%   176, 229, 402
src/synapse/workload.py                   138      6     24      0    94%   401-402, 412-415
src/synapse/workload_configuration.py     148     26     34     12    79%   88->exit, 92-93, 141-142, 171, 191-192, 224-225, 258, 267-268, 283, 288-289, 310-311, 330->335, 336, 354->356, 366-367, 395, 403->405, 405->407, 412-413, 433->440, 443, 463-464
src/user.py                                23      0      2      0   100%
-----------------------------------------------------------------------------------
TOTAL                                    1947    132    344     61    91%

Static code analysis report

Working... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Run started:2024-12-03 19:06:20.417336

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 10878
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 merged commit ef70024 into 2/main Dec 4, 2024
21 checks passed
@Thanhphan1147 Thanhphan1147 deleted the disable_saml_integration branch December 4, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants