Taking additional targets from osci.yaml #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osci also has targets so added them. [1] https://review.opendev.org/c/openstack/charm-manila-ganesha/+/925662/5/osci.yaml
|
I need to check duplicated job between tests.yaml and osci.yaml |
|
having discussed with the Openstack team how this works and why the manila-ganehsa charm has the job configured that way i wrote https://github.com/canonical/stsstack-bundles/pull/238/files which can supersede this patch. |
|
replaced by 238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osci also has targets so added them.
[1] https://review.opendev.org/c/openstack/charm-manila-ganesha/+/925662/5/osci.yaml
Resolves: #234
currently it runs
focal-yoga
jammy-yoga from tests.yaml
but I think vault:jammy-yoga-vault also needed from osci.yaml