Ignore errors when listing subnets #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On STSStack, the first call to `openstack subnets` is expected to fail. The script needs to ignore this failure. Signed-off-by: Nicolas Bock <[email protected]>
drencrom
approved these changes
May 24, 2024
brianphaley
requested changes
May 24, 2024
| @@ -12,10 +12,10 @@ update_master_opts ${MOD_PASSTHROUGH_OPTS[@]} | |||
| vip_start=${MASTER_OPTS[VIP_ADDR_START]} | |||
| if [[ -z $vip_start ]]; then | |||
| # prodstack | |||
| cidr=$(source ~/novarc; openstack subnet show subnet_${OS_USERNAME} -c cidr -f value 2>/dev/null) | |||
| cidr=$(source ~/novarc; openstack subnet show subnet_${OS_USERNAME} -c cidr -f value 2>/dev/null || true) | |||
There was a problem hiding this comment.
The original change merged before I looked at it, but using 'subnet list' is maybe the better choice:
openstack subnet list --name subnet_${OS_USERNAME} -c Subnet -f value
I don't have a subnet_brian-haley, but I do have an admin_subnet:
$ openstack subnet list --name subnet_brian-haley -c Subnet -f value
$ openstack subnet list --name brian-haley_admin_subnet -c Subnet -f value
10.5.0.0/16
There was a problem hiding this comment.
On PS6, your username is a little strange. Mine is stg-reproducer-nbock. On STSStack it is nicolasbock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On STSStack, the first call to
openstack subnetsis expected to fail.The script needs to ignore this failure.
Signed-off-by: Nicolas Bock [email protected]