Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tox and set python version for running the CI on snaps #90

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Pin tox and set python version for running the CI on snaps #90

merged 5 commits into from
Sep 23, 2024

Conversation

gabrielcocenza
Copy link
Member

  • snaps were missing the pinning on tox that can cause workflow breaks on major versions as it happens with charms
  • setting python3.10 as the standard for running lint

@gabrielcocenza
Pin tox and set python version for running the CI on snaps
100e0c3 
- snaps were missing the pinning on tox that can cause workflow
  breaks on major versions as it happens with charms
- setting python3.10 as the standard for running lint
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner September 19, 2024 14:13
Deezzir
Deezzir requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the Python lint check as we discussed

Deezzir
Deezzir approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gabrielcocenza gabrielcocenza merged commit 700979e into main Sep 23, 2024
46 checks passed
@samuelallan72 samuelallan72 deleted the pin-tox-snap branch September 23, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deezzir Deezzir Deezzir approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcocenza @samuelallan72 @Deezzir