Stop PRs to same repo interfering with each other #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the branch name was static, which caused issues when terraform opens PRs to multiple target branches to the same repository. This is because the terraform run for each target branch was trying to work on the same branch, and opening PRs from the same branch. This was observed in repos when we maintain multiple branches (eg. snap-tempest with main, stable/caracal, stable/bobcat, etc.). This fixes it by including the target branch name in the PR branch, ensuring that each PR in a target repository will use its own branch, and there won't be any more cross interference. Fixes: #88
samuelallan72
requested review from
Pjack,
aieri,
jneo8,
gabrielcocenza,
rgildein,
Deezzir and
chanchiwai-ray
Pjack
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the branch name was static,
which caused issues when terraform opens PRs to multiple target branches to the same repository.
This is because the terraform run for each target branch was trying to work on the same branch,
and opening PRs from the same branch.
This was observed in repos when we maintain multiple branches (eg. snap-tempest with main, stable/caracal, stable/bobcat, etc.).
This fixes it by including the target branch name in the PR branch, ensuring that each PR in a target repository will use its own branch, and there won't be any more cross interference.
Fixes: #88