Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm64 builds for charm-local-users #39

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

samuelallan72
Copy link
Contributor

@samuelallan72 samuelallan72 commented Aug 5, 2024

This ports the release.yaml changes from charm-local-users to here. :)

@samuelallan72 samuelallan72 marked this pull request as draft August 5, 2024 08:10
@samuelallan72
Copy link
Contributor Author

samuelallan72 commented Aug 5, 2024

From my refactor #38 :

type any will be required if we want template variables of other types - for example a list of architectures to run on (useful for multiarch releases coming soon)

Unfortunately it turned out this didn't actually work:

The given value is not suitable for var.templates declared at
variables.tf:22,1-21: cannot find a common base type for all elements.

So we need to use string values for everything with the current implementation anyway.

@samuelallan72 samuelallan72 marked this pull request as ready for review August 5, 2024 23:39
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question, otherwise LGTM

@samuelallan72 samuelallan72 merged commit a83cba1 into main Aug 6, 2024
3 checks passed
@samuelallan72 samuelallan72 deleted the multiarch-release branch August 6, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants