fix(terraform): Fix wrong repo configuration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jneo8
commented
Jun 4, 2024
•
jneo8
commented
- For branch protection rule
- Remove force_push_bypassers
- Remove dismissal_restrictions
- Add vulnerability_alerts=true for repo setting
jneo8
requested review from
Pjack,
aieri,
samuelallan72,
gabrielcocenza,
rgildein and
chanchiwai-ray
- For branch protection rule - Remove force_push_bypassers - Remove dismissal_restrictions - Add vulnerability_alerts=true for repo setting
jneo8
force-pushed
the
fix/terraform-change-repo-settings
branch
from
969c5f7 to
8f050b6
Compare
Pjack
requested changes
Jun 4, 2024
Pjack
approved these changes
Jun 5, 2024
|
FYI: Those settings were there to mimic what was possible before. Terraform will set "Do not allow bypassing the above settings ", so without any bypass even admin of repo should not do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.