Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/how to create testing environment for terraform #24

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Doc/how to create testing environment for terraform #24

merged 5 commits into from
Jun 5, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Jun 3, 2024

Follow #19

@jneo8 jneo8 requested a review from a team as a code owner June 3, 2024 08:35
@jneo8 jneo8 force-pushed the doc/how-to-create-testing-environment-for-terraform branch from 3b03611 to 78c1f46 Compare June 4, 2024 08:45
@jneo8 jneo8 requested a review from samuelallan72 June 4, 2024 09:08
samuelallan72
samuelallan72 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneo8 jneo8 merged commit 736d355 into main Jun 5, 2024
1 check passed
@chanchiwai-ray chanchiwai-ray deleted the doc/how-to-create-testing-environment-for-terraform branch June 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jneo8 @samuelallan72 @rgildein @chanchiwai-ray