Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first POC with GH settings and CODEOWNERS #14

Merged
merged 6 commits into from
May 30, 2024
Merged

first POC with GH settings and CODEOWNERS #14

merged 6 commits into from
May 30, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented May 17, 2024 •
edited
Loading

This is an enhancement for trying to GitHub repo settings via terraform and providing also files like CODEOWNER.

@rgildein rgildein added the enhancement New feature or request label May 17, 2024
@rgildein rgildein self-assigned this May 17, 2024
@rgildein rgildein force-pushed the chore/BSENG-2445/terraform-poc branch from e6e3d14 to 8769616 Compare May 17, 2024 11:32
@rgildein rgildein force-pushed the chore/BSENG-2445/terraform-poc branch 5 times, most recently from 908d73f to 3ce8397 Compare May 17, 2024 11:44
@rgildein rgildein force-pushed the chore/BSENG-2445/terraform-poc branch from 3ce8397 to 6c30887 Compare May 17, 2024 12:05
@rgildein rgildein marked this pull request as ready for review May 27, 2024 06:49
@rgildein rgildein requested a review from a team as a code owner May 27, 2024 06:49
@chanchiwai-ray
Copy link
Contributor

chanchiwai-ray commented May 27, 2024 •
edited
Loading

Can you add .terraform.lock.hcl and .terraform to .gitignore to avoid adding them git history? (note you didn't add them in this PR)

Pjack
Pjack requested changes May 27, 2024
View reviewed changes
terraform-plans/modules/GitHub/settings/main.tf Outdated Show resolved Hide resolved
terraform-plans/modules/GitHub/settings/main.tf Show resolved Hide resolved
terraform-plans/modules/GitHub/settings/main.tf Outdated Show resolved Hide resolved
This was referenced May 29, 2024
Closed
Closed
jneo8
jneo8 previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open #16 and #17 to trace issues. Other is LGTM.

@rgildein rgildein requested a review from jneo8 May 29, 2024 06:39
@jneo8 jneo8 mentioned this pull request May 29, 2024
Merged
samuelallan72
samuelallan72 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneo8 jneo8 merged commit f368238 into main May 30, 2024
1 check passed
jneo8 added a commit that referenced this pull request May 30, 2024
@jneo8
Doc/terraform readme (#18)
6d721be 
Follow: #14
@rgildein rgildein deleted the chore/BSENG-2445/terraform-poc branch May 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray left review comments

@jneo8 jneo8 jneo8 approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@rgildein rgildein

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rgildein @chanchiwai-ray @Pjack @samuelallan72 @jneo8