Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable check.yaml for the following projects #134

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Temporarily disable check.yaml for the following projects #134

merged 2 commits into from
Dec 11, 2024

Conversation

chanchiwai-ray
Copy link
Contributor

Temporarily disable check.yaml for the following projects since they don't fit in existing template

  • charm-prometheus-juju-exporter
  • prometheus-juju-exporter
  • hardware-observer-operator

@chanchiwai-ray
Temporarily disable check.yaml for the following project.
2002818 
- charm-prometheus-juju-exporter
- prometheus-juju-exporter
- hardware-observer-operator
@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner December 11, 2024 02:13
Deezzir
Deezzir approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the plan for changes? Are we going to bring them back in the future? I think we need to document it somewhere, so it's trackable

@samuelallan72
Copy link
Contributor

What's the plan for changes? Are we going to bring them back in the future? I think we need to document it somewhere, so it's trackable

+1 please open a jira ticket or a github issue here to add them back. @chanchiwai-ray

@samuelallan72 samuelallan72 merged commit 94fa426 into main Dec 11, 2024
49 checks passed
@samuelallan72 samuelallan72 deleted the workaround branch December 11, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deezzir Deezzir Deezzir approved these changes

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@Vultaire Vultaire Awaiting requested review from Vultaire Vultaire is a code owner automatically assigned from canonical/soleng-reviewers

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@samuelallan72 samuelallan72 Awaiting requested review from samuelallan72 samuelallan72 is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanchiwai-ray @samuelallan72 @gabrielcocenza @Deezzir