Use tox environment for the TICS workflow

[Deezzir]

Depends on the following PRs to be merged first:

• Add deps for the tics tox target smartctl-exporter-snap#23
• Add deps for the tics tox target dcgm-snap#51
• Add deps for the tics tox target charmed-openstack-exporter-snap#17

[jneo8]

Need information

[samuelallan72]

I'm uneasy about this. Why would the tics target require all the same dependencies as the functional tests as well? It feels like merging requirements of the tics tox target, and the tics github action will cause confusion, because it's not a clear separation of concerns for the dependencies.

Can we treat the tics action dependencies separate to the tox target dependencies? Maybe even by creating our own virtualenvironment for the tics action to use.

If we do go down the route of sharing the tox environment, please clearly document with code comments the purpose of the extra dependencies, and note that the tox environment is manually used for the tics github action?

[Deezzir]

https://warthogs.atlassian.net/browse/TICSISSUES-3 Please see the issue, unfortunately, it's the way to go. The TICS analysis requires test dependencies to be present to analyze the code and code paths. Additionally, i think it also analyzes deps for the known issues.

@samuelallan72

[samuelallan72]

@Deezzir ah sorry, thanks for the information.

In that case, it sounds like sharing the tox environment is the way to go. 👍 👍

[samuelallan72]

LGTM. Thanks for adding comments for context. 👍