Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap templates for charmed-openstack-exporter-snap #124

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

Deezzir
Copy link
Contributor

@Deezzir Deezzir commented Dec 2, 2024

@Deezzir Deezzir requested a review from a team as a code owner December 2, 2024 21:53
@samuelallan72 samuelallan72 changed the title Add snap templates for charmed-openstack-exporter Add snap templates for charmed-openstack-exporter-snap Dec 2, 2024
samuelallan72
samuelallan72 previously approved these changes Dec 2, 2024
aieri
aieri previously approved these changes Dec 2, 2024
@Deezzir Deezzir dismissed stale reviews from aieri and samuelallan72 via 9fe4ec5 December 3, 2024 04:18
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Samel's comment. Other LGTM.

@samuelallan72 samuelallan72 merged commit 1ed0c4b into main Dec 3, 2024
47 checks passed
@samuelallan72 samuelallan72 deleted the track-charmed-openstack-exporter-snap branch December 3, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage charmed-openstack-exporter-snap
4 participants