Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-delete branches on PR merge #121

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Auto-delete branches on PR merge #121

merged 2 commits into from
Dec 3, 2024

Conversation

samuelallan72
Copy link
Contributor

As far as I know, we never have cases where we want to keep the branch after a PR has merged.
And if we do on a rare occasion,
it should be easy to restore the branch.

Auto-deleting brings some conveniences,
including more efficiency and less forgotten stale branches.

Fixes: #106

@samuelallan72
Auto-delete branches on PR merge
00f555b 
As far as I know, we never have cases where we want to keep the branch
after a PR has merged.
And if we do on a rare occasion,
it should be easy to restore the branch.

Auto-deleting brings some conveniences,
including more efficiency and less forgotten stale branches.

Fixes: #106
@samuelallan72 samuelallan72 requested a review from a team as a code owner November 29, 2024 02:01
Pjack
Pjack reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial a conversation to gather feedback from the team.
If no concerns are raised within a couple of days, we can proceed with merging.

@Pjack Pjack self-requested a review November 29, 2024 02:51
Pjack
Pjack requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial a conversation to gather feedback from the team.
If no concerns are raised within a couple of days, we can proceed with merging.

@Pjack Pjack self-requested a review November 29, 2024 02:51
Pjack
Pjack reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Pjack Pjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial a conversation to gather feedback from the team.
If no concerns are raised within a couple of days, we can proceed with merging.

gabrielcocenza
gabrielcocenza approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see downsides on deleting the branch. LGTM

@samuelallan72 samuelallan72 requested a review from Pjack December 1, 2024 22:21
@samuelallan72 samuelallan72 merged commit b41a128 into main Dec 3, 2024
47 checks passed
@samuelallan72 samuelallan72 deleted the del-branch branch December 3, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@jneo8 jneo8 jneo8 approved these changes

@Pjack Pjack Pjack approved these changes

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-delete branches on PR merge
5 participants
@samuelallan72 @Pjack @jneo8 @gabrielcocenza @chanchiwai-ray