Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update apply logic" #119

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Pjack
Copy link
Contributor

@Pjack Pjack commented Nov 27, 2024

Reverts #112

Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I approve of this revert is that creating a PR before actually merging it can lead to issues where files become misaligned in the end.

For example, imagine Person A creates a PR that spawns multiple child PRs. At the same time, Person B creates another PR with its own set of child PRs. In such a scenario, it becomes crucial to ensure that there are no conflicts between the two original PRs and that all the child PRs are merged in the correct order.

While the original issue we aimed to address—testing the PR before merging—does get resolved, this approach introduces a new challenge. When multiple people work on the repository simultaneously, there’s a real risk of misalignment, which can complicate the process.

@Pjack Pjack merged commit d1a54d8 into main Nov 27, 2024
47 checks passed
@samuelallan72 samuelallan72 deleted the revert-112-chore/SOLENG-844/change-apply-logic branch November 27, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants