Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSDLC - Vulnerability Response #108

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

gabrielcocenza
Copy link
Member

@gabrielcocenza gabrielcocenza commented Oct 21, 2024

Add the SECURITY.md file

As part of the SSDLC projects should add SECURITY.md file in all public repositories.

SolEng Vulnerability Response is already approved from the SSDLC spec

@gabrielcocenza gabrielcocenza requested a review from a team as a code owner October 21, 2024 18:22
@gabrielcocenza gabrielcocenza marked this pull request as draft October 21, 2024 18:23
@gabrielcocenza gabrielcocenza force-pushed the SSDLC_vulnerability_response branch 4 times, most recently from 7eb3153 to 3959585 Compare October 21, 2024 18:52
@gabrielcocenza gabrielcocenza force-pushed the SSDLC_vulnerability_response branch from 3959585 to d3bb3f0 Compare October 21, 2024 18:54
@gabrielcocenza gabrielcocenza marked this pull request as ready for review October 21, 2024 19:01
@gabrielcocenza
Copy link
Member Author

This is a POC PR to add the SECURITY.md file at the dcgm snap repo. IMO we can merge this and if it behaves as expected we can add it to all the other projects

terraform-plans/templates/github/SECURITY.md.tftpl Outdated Show resolved Hide resolved
terraform-plans/templates/github/SECURITY.md.tftpl Outdated Show resolved Hide resolved
Deezzir
Deezzir previously approved these changes Oct 25, 2024
Copy link
Contributor

@Deezzir Deezzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanchiwai-ray
Copy link
Contributor

this is stale for some time, any update?

Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to add this guidance to all projects.

@gabrielcocenza gabrielcocenza dismissed samuelallan72’s stale review December 10, 2024 18:17

change requests were addressed

@gabrielcocenza gabrielcocenza merged commit cb7f05e into main Dec 10, 2024
5 checks passed
@gabrielcocenza gabrielcocenza deleted the SSDLC_vulnerability_response branch December 10, 2024 18:18
gabrielcocenza added a commit that referenced this pull request Dec 11, 2024
Similar to #108, this adds SECURITY.md to the soleng projects as
part of the SSDLC
gabrielcocenza added a commit that referenced this pull request Dec 11, 2024
Similar to #108, this adds SECURITY.md to the soleng projects as
part of the SSDLC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants